Refactor arrtrix webhook to use fixed path and remove legacy config
Some checks failed
Test action / kaas (push) Failing after 1s
Some checks failed
Test action / kaas (push) Failing after 1s
- Switch arrtrix webhook to a fixed path: /_arrtrix/webhook - Remove Radarr-specific and secret-based config from arrtrix - Simplify connector and webhook handler logic - Update NixOS module to drop legacy webhook config - Add new tests for generic arrtrix webhook handler
This commit is contained in:
parent
fe627f3aab
commit
bbfe6867c8
11 changed files with 211 additions and 285 deletions
114
packages/arrtrix/pkg/webhook/arr_test.go
Normal file
114
packages/arrtrix/pkg/webhook/arr_test.go
Normal file
|
|
@ -0,0 +1,114 @@
|
|||
package webhook
|
||||
|
||||
import (
|
||||
"context"
|
||||
"errors"
|
||||
"net/http"
|
||||
"net/http/httptest"
|
||||
"strings"
|
||||
"testing"
|
||||
|
||||
"maunium.net/go/mautrix/id"
|
||||
)
|
||||
|
||||
type stubRoomResolver struct {
|
||||
roomID id.RoomID
|
||||
err error
|
||||
}
|
||||
|
||||
func (s stubRoomResolver) ResolveManagementRoom(context.Context) (id.RoomID, error) {
|
||||
return s.roomID, s.err
|
||||
}
|
||||
|
||||
type stubNoticeSender struct {
|
||||
roomID id.RoomID
|
||||
message string
|
||||
err error
|
||||
}
|
||||
|
||||
func (s *stubNoticeSender) SendNotice(_ context.Context, roomID id.RoomID, message string) error {
|
||||
s.roomID = roomID
|
||||
s.message = message
|
||||
return s.err
|
||||
}
|
||||
|
||||
func TestMountArrRequiresBridge(t *testing.T) {
|
||||
router := http.NewServeMux()
|
||||
if err := MountArr(router, nil); err == nil {
|
||||
t.Fatal("expected nil bridge to fail")
|
||||
}
|
||||
}
|
||||
|
||||
func TestArrHandlerDeliversNotice(t *testing.T) {
|
||||
sender := &stubNoticeSender{}
|
||||
handler := &ArrHandler{
|
||||
resolver: stubRoomResolver{roomID: "!room:test"},
|
||||
sender: sender,
|
||||
}
|
||||
|
||||
req := httptest.NewRequest(http.MethodPost, ArrWebhookPath, strings.NewReader(`{"eventType":"Download","movie":{"title":"Dune","year":2021,"imdbId":"tt1160419"},"movieFile":{"quality":"1080p","relativePath":"Dune (2021)/Dune.mkv"},"isUpgrade":false}`))
|
||||
rec := httptest.NewRecorder()
|
||||
handler.ServeHTTP(rec, req)
|
||||
|
||||
if rec.Code != http.StatusAccepted {
|
||||
t.Fatalf("expected accepted status, got %d", rec.Code)
|
||||
}
|
||||
if sender.roomID != "!room:test" {
|
||||
t.Fatalf("expected notice sent to management room, got %q", sender.roomID)
|
||||
}
|
||||
if !strings.Contains(sender.message, "**Arr Download**") || !strings.Contains(sender.message, "Dune (2021)") {
|
||||
t.Fatalf("unexpected message: %s", sender.message)
|
||||
}
|
||||
}
|
||||
|
||||
func TestArrHandlerReportsAmbiguousManagementRoom(t *testing.T) {
|
||||
handler := &ArrHandler{
|
||||
resolver: stubRoomResolver{err: ErrAmbiguousManagementRoom},
|
||||
sender: &stubNoticeSender{},
|
||||
}
|
||||
|
||||
req := httptest.NewRequest(http.MethodPost, ArrWebhookPath, strings.NewReader(`{"eventType":"Test"}`))
|
||||
rec := httptest.NewRecorder()
|
||||
handler.ServeHTTP(rec, req)
|
||||
|
||||
if rec.Code != http.StatusConflict {
|
||||
t.Fatalf("expected conflict status, got %d", rec.Code)
|
||||
}
|
||||
}
|
||||
|
||||
func TestRenderNoticeForTestEvent(t *testing.T) {
|
||||
msg := renderNotice(payload{EventType: "Test"})
|
||||
if strings.TrimSpace(msg) != "**Arr Test**" {
|
||||
t.Fatalf("unexpected test-event message: %q", msg)
|
||||
}
|
||||
}
|
||||
|
||||
func TestArrHandlerReturnsBadGatewayOnSendFailure(t *testing.T) {
|
||||
handler := &ArrHandler{
|
||||
resolver: stubRoomResolver{roomID: "!room:test"},
|
||||
sender: &stubNoticeSender{err: errors.New("send failed")},
|
||||
}
|
||||
|
||||
req := httptest.NewRequest(http.MethodPost, ArrWebhookPath, strings.NewReader(`{"eventType":"Test"}`))
|
||||
rec := httptest.NewRecorder()
|
||||
handler.ServeHTTP(rec, req)
|
||||
|
||||
if rec.Code != http.StatusBadGateway {
|
||||
t.Fatalf("expected bad gateway status, got %d", rec.Code)
|
||||
}
|
||||
}
|
||||
|
||||
func TestArrHandlerRejectsMissingEventType(t *testing.T) {
|
||||
handler := &ArrHandler{
|
||||
resolver: stubRoomResolver{roomID: "!room:test"},
|
||||
sender: &stubNoticeSender{},
|
||||
}
|
||||
|
||||
req := httptest.NewRequest(http.MethodPost, ArrWebhookPath, strings.NewReader(`{"movie":{"title":"Dune"}}`))
|
||||
rec := httptest.NewRecorder()
|
||||
handler.ServeHTTP(rec, req)
|
||||
|
||||
if rec.Code != http.StatusBadRequest {
|
||||
t.Fatalf("expected bad request status, got %d", rec.Code)
|
||||
}
|
||||
}
|
||||
Loading…
Add table
Add a link
Reference in a new issue