for the most part switched out the grid's internals for the new table component

This commit is contained in:
Chris Kruining 2024-12-11 16:24:54 +01:00
parent 6d74950495
commit d219ae1f9a
No known key found for this signature in database
GPG key ID: EB894A3560CCCAD2
8 changed files with 151 additions and 218 deletions

View file

@ -1,13 +1,13 @@
export type RowNode<T> = { kind: 'row', key: string, value: T }
export type GroupNode<T> = { kind: 'group', key: string, groupedBy: keyof T, nodes: Node<T>[] };
export type Node<T> = RowNode<T> | GroupNode<T>;
export type DataSetRowNode<T> = { kind: 'row', key: string, value: T }
export type DataSetGroupNode<T> = { kind: 'group', key: string, groupedBy: keyof T, nodes: DataSetNode<T>[] };
export type DataSetNode<T> = DataSetRowNode<T> | DataSetGroupNode<T>;
export type DataSet<T extends Record<string, any>> = Node<T>[];
export type DataSet<T extends Record<string, any>> = DataSetNode<T>[];
export const createDataSet = <T extends Record<string, any>>(data: T[]): Node<T>[] => {
return Object.entries(data).map<RowNode<T>>(([key, value]) => ({ kind: 'row', key, value }));
export const createDataSet = <T extends Record<string, any>>(data: T[]): DataSetNode<T>[] => {
return Object.entries(data).map<DataSetRowNode<T>>(([key, value]) => ({ kind: 'row', key, value }));
};
type SortingFunction<T> = (a: T, b: T) => -1 | 0 | 1;
@ -22,6 +22,6 @@ export const toSorted = <T extends Record<string, any>>(dataSet: DataSet<T>, sor
return sorted;
};
type GroupingFunction<T> = (nodes: RowNode<T>[]) => Node<T>[];
type GroupingFunction<T> = (nodes: DataSetRowNode<T>[]) => DataSetNode<T>[];
type GroupOptions<T extends Record<string, any>> = { by: keyof T, with: GroupingFunction<T> };
export const toGrouped = <T extends Record<string, any>>(dataSet: DataSet<T>, group: GroupOptions<T>): DataSet<T> => group.with(dataSet as any);

View file

@ -1,5 +1,5 @@
export type { Column } from './table';
export type { DataSet, GroupNode, RowNode, Node } from './dataset';
export type { DataSet, DataSetGroupNode, DataSetRowNode, DataSetNode } from './dataset';
export { SelectionMode, Table } from './table';
export { createDataSet, toSorted, toGrouped } from './dataset';

View file

@ -1,6 +1,6 @@
import { Accessor, createContext, createEffect, createMemo, createSignal, For, JSX, Match, Show, Switch, useContext } from "solid-js";
import { selectable, SelectionProvider, useSelection } from "~/features/selectable";
import { type RowNode, type GroupNode, type Node, createDataSet, toSorted, toGrouped } from './dataset';
import { DataSetRowNode, DataSetGroupNode, DataSetNode, createDataSet, toSorted, toGrouped } from './dataset';
import css from './table.module.css';
import { createStore } from "solid-js/store";
import { FaSolidSort, FaSolidSortDown, FaSolidSortUp } from "solid-icons/fa";
@ -11,15 +11,27 @@ export type Column<T> = {
id: keyof T,
label: string,
sortable?: boolean,
readonly groupBy?: (rows: RowNode<T>[]) => Node<T>[],
readonly groupBy?: (rows: DataSetRowNode<T>[]) => DataSetNode<T>[],
};
type SelectionItem<T> = { key: string, value: Accessor<T>, element: WeakRef<HTMLElement> };
export interface TableApi<T extends Record<string, any>> {
readonly selection: Accessor<SelectionItem<T>[]>;
readonly rows: Accessor<T[]>;
readonly columns: Accessor<Column<T>[]>;
selectAll(): void;
clear(): void;
}
const TableContext = createContext<{
readonly rows: Accessor<any[]>,
readonly columns: Accessor<Column<any>[]>,
readonly selection: Accessor<any[]>,
readonly selectionMode: Accessor<SelectionMode>,
readonly groupBy: Accessor<string | undefined>,
readonly sort: Accessor<{ by: string, reversed?: boolean } | undefined>,
readonly cellRenderers: Accessor<Record<string, (cell: { value: any }) => JSX.Element>>,
readonly cellRenderers: Accessor<Record<string, (cell: { key: string, value: any }) => JSX.Element>>,
setSort(setter: (current: { by: string, reversed?: boolean } | undefined) => { by: string, reversed: boolean } | undefined): void;
}>();
@ -27,8 +39,8 @@ const TableContext = createContext<{
const useTable = () => useContext(TableContext)!
function defaultGroupingFunction<T>(groupBy: keyof T) {
return (nodes: RowNode<T>[]): Node<T>[] => Object.entries(Object.groupBy<any, RowNode<T>>(nodes, r => r.value[groupBy]))
.map<GroupNode<T>>(([key, nodes]) => ({ kind: 'group', key, groupedBy: groupBy, nodes: nodes! }));
return (nodes: DataSetRowNode<T>[]): DataSetNode<T>[] => Object.entries(Object.groupBy<any, DataSetRowNode<T>>(nodes, r => r.value[groupBy]))
.map<DataSetGroupNode<T>>(([key, nodes]) => ({ kind: 'group', key, groupedBy: groupBy, nodes: nodes! }));
}
export enum SelectionMode {
@ -47,11 +59,11 @@ type TableProps<T extends Record<string, any>> = {
},
selectionMode?: SelectionMode,
children?: { [K in keyof T]?: (cell: { value: T[K] }) => JSX.Element },
api?: (api: TableApi<T>) => any,
};
export function Table<T extends Record<string, any>>(props: TableProps<T>) {
const [selection, setSelection] = createSignal<object[]>([]);
const [selection, setSelection] = createSignal<T[]>([]);
const [state, setState] = createStore({
sort: props.sort ? { by: props.sort.by as string, reversed: props.sort.reversed } : undefined,
});
@ -60,13 +72,16 @@ export function Table<T extends Record<string, any>>(props: TableProps<T>) {
setState('sort', props.sort ? { by: props.sort.by as string, reversed: props.sort.reversed } : undefined);
});
const rows = createMemo<T[]>(() => props.rows ?? []);
const columns = createMemo<Column<T>[]>(() => props.columns ?? []);
const selectionMode = createMemo(() => props.selectionMode ?? SelectionMode.None);
const groupBy = createMemo(() => props.groupBy as string | undefined);
const cellRenderers = createMemo(() => props.children ?? {});
const context = {
rows,
columns,
selection,
selectionMode,
groupBy,
sort: createMemo(() => state.sort),
@ -78,8 +93,10 @@ export function Table<T extends Record<string, any>>(props: TableProps<T>) {
};
return <TableContext.Provider value={context}>
<SelectionProvider selection={setSelection} multiSelect>
<InnerTable class={props.class} rows={props.rows} />
<SelectionProvider selection={setSelection} multiSelect={props.selectionMode === SelectionMode.Multiple}>
<Api api={props.api} />
<InnerTable class={props.class} rows={rows()} />
</SelectionProvider>
</TableContext.Provider>;
};
@ -91,7 +108,7 @@ function InnerTable<T extends Record<string, any>>(props: InnerTableProps<T>) {
const selectable = createMemo(() => table.selectionMode() !== SelectionMode.None);
const columnCount = createMemo(() => table.columns().length);
const nodes = createMemo<Node<T>[]>(() => {
const nodes = createMemo<DataSetNode<T>[]>(() => {
const columns = table.columns();
const groupBy = table.groupBy();
const sort = table.sort();
@ -121,6 +138,31 @@ function InnerTable<T extends Record<string, any>>(props: InnerTableProps<T>) {
</section>
};
function Api<T extends Record<string, any>>(props: { api: undefined | ((api: TableApi<T>) => any) }) {
const table = useTable();
const selectionContext = useSelection<SelectionItem<T>>();
const api: TableApi<T> = {
selection: createMemo(() => {
return selectionContext.selection();
}),
rows: table.rows,
columns: table.columns,
selectAll() {
selectionContext.selectAll();
},
clear() {
selectionContext.clear();
},
};
createEffect(() => {
props.api?.(api);
});
return null;
};
function Head<T extends Record<string, any>>(props: {}) {
const table = useTable();
const context = useSelection();
@ -174,7 +216,7 @@ function Head<T extends Record<string, any>>(props: {}) {
</header>;
};
function Node<T extends Record<string, any>>(props: { node: Node<T>, depth: number, groupedBy?: keyof T }) {
function Node<T extends Record<string, any>>(props: { node: DataSetNode<T>, depth: number, groupedBy?: keyof T }) {
return <Switch>
<Match when={props.node.kind === 'row' ? props.node : undefined}>{
row => <Row key={row().key} value={row().value} depth={props.depth} groupedBy={props.groupedBy} />
@ -201,12 +243,12 @@ function Row<T extends Record<string, any>>(props: { key: string, value: T, dept
</Show>
<For each={values()}>{
([k, v]) => <div class={css.cell}>{table.cellRenderers()[k]?.({ value: v }) ?? v}</div>
([k, value]) => <div class={css.cell}>{table.cellRenderers()[k]?.({ key: `${props.key}.${k}`, value }) ?? value}</div>
}</For>
</div>;
};
function Group<T extends Record<string, any>>(props: { key: string, groupedBy: keyof T, nodes: Node<T>[], depth: number }) {
function Group<T extends Record<string, any>>(props: { key: string, groupedBy: keyof T, nodes: DataSetNode<T>[], depth: number }) {
const table = useTable();
return <details open>

View file

@ -61,44 +61,9 @@
}
.tab {
position: absolute;
grid-area: 2 / 1 / span 1 / span 1;
inline-size: 100%;
block-size: 100%;
&:not(.active) {
display: none;
}
& > summary {
grid-row: 1 / 1;
padding: var(--padding-s) var(--padding-m);
&::marker {
content: none;
}
}
&::details-content {
grid-area: 2 / 1 / span 1 / span var(--tab-count);
display: none;
grid: 100% / 100%;
inline-size: 100%;
block-size: 100%;
overflow: auto;
}
&[open] {
& > summary {
background-color: var(--surface-600);
}
&::details-content {
display: grid;
}
}
display: contents;
background-color: var(--surface-600);
color: var(--text-1);
}
}

View file

@ -95,19 +95,12 @@ export const Tab: ParentComponent<{ id: string, label: string, closable?: boolea
const context = useTabs();
const resolved = children(() => props.children);
const isActive = context.isActive(props.id);
const [ref, setRef] = createSignal();
// const isActive = context.register(props.id, props.label, {
// closable: props.closable ?? false,
// ref: ref,
// });
return <div
ref={setRef()}
id={props.id}
class={css.tab}
data-tab-label={props.label}
data-tab-closable={props.closable}
style="display: contents;"
>
<Show when={isActive()}>
<Command.Context for={context.onClose() ?? noop} with={[props.id]}>{resolved()}</Command.Context>